Flowee/pay
1
Fork 0
Code Issues Pull Requests Releases 32 Wiki Activity
Files
2023.08.0
pay/testing/value/TestValue.cpp
T
tomFlowee 7e375f50b5 Bugfix how we handle numbers from user input 
This is a long overdue cleanup around the ideas of entering
numbers in Flowee Pay.

The core dataclass BitcoinValue now keeps track where the number
came from, either user input or some calculation. This allows
us to have the Fiat and the Coin price stay in sync without weird
problems.
The one we type uses a string, the price field that we are not typing in
is then a slave and we follow the auto-generated number as the
source.

This solves a host of known issues:

* Editing of value objects is much more consistnnt and predictable now.
* Switching to a different fiat type now properly re-calculates the
  values that are slaved. So if the primary is a BCH value then the fiat
  value gets the new exhange rate instantly applied.
* Switching to a different fiat type properly applies having a separator
  So if you go from euro to Japanese yen, we now remove the separator
  and the numbers behind it.
* Changing the app setting from BCH to mBCH now properly updates all
  amounts. Notice that the user-typed string wins, if you typed 2 and
  then change to mBCH we assume you wanted 2, not 2000.
* Paste now works more logcally.
* Cursor is no longer sometimes invisible, requiring backspace to make
  it show up.

And last we now protect against too large numbers. It is seen as an
error to type a number above 21 million BCH.

Fixes #19
2023-06-23 10:35:35 +02:00

239 lines
8.1 KiB
C++
Raw Permalink Blame History

/*
* This file is part of the Flowee project
* Copyright (C) 2021-2023 Tom Zander <tom@flowee.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "TestValue.h"
#include <BitcoinValue.h>
#include <FloweePay.h>
class MockBitcoinValue : public BitcoinValue
{
public:
void setEnteredString(const QString &string)
{
bool started = false;
setCursorPos(0);
m_typedNumber.clear();
for (int i = 0; i < string.size(); ++i) {
auto k = string.at(i);
if (k.isDigit()) {
started = true;
insertNumber(k);
}
else if ((started || (string.size() > i + 1 && string.at(i+1).isDigit()))
&& (k.unicode() == ',' || k.unicode() == '.')) {
addSeparator();
}
else if (started)
return;
}
if (!m_cursorPos)
setValue(0, UserInput);
}
};
void TestValue::init()
{
FloweePay::instance()->setUnit(FloweePay::BCH);
}
void TestValue::basics()
{
MockBitcoinValue testObject;
testObject.setRealValue(8790.9); // We only use the whole
QCOMPARE(testObject.value(), 8790);
testObject.setEnteredString("1.1945");
QCOMPARE(testObject.value(), 119450000);
QCOMPARE(testObject.cursorPos(), 6);
testObject.insertNumber('1');
QCOMPARE(testObject.value(), 119451000);
QCOMPARE(testObject.cursorPos(), 7);
testObject.insertNumber('2');
QCOMPARE(testObject.value(), 119451200);
QCOMPARE(testObject.cursorPos(), 8);
testObject.insertNumber('4');
QCOMPARE(testObject.value(), 119451240);
QCOMPARE(testObject.cursorPos(), 9);
testObject.insertNumber('9');
QCOMPARE(testObject.value(), 119451249);
QCOMPARE(testObject.cursorPos(), 10);
testObject.insertNumber('4'); // no effect
QCOMPARE(testObject.value(), 119451249);
QCOMPARE(testObject.cursorPos(), 10);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119451240);
QCOMPARE(testObject.cursorPos(), 9);
testObject.insertNumber('4');
QCOMPARE(testObject.value(), 119451244);
QCOMPARE(testObject.cursorPos(), 10);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119451240);
QCOMPARE(testObject.cursorPos(), 9);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119451200);
QCOMPARE(testObject.cursorPos(), 8);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119451000);
QCOMPARE(testObject.cursorPos(), 7);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119450000);
QCOMPARE(testObject.cursorPos(), 6);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119400000);
QCOMPARE(testObject.cursorPos(), 5);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 119000000);
QCOMPARE(testObject.cursorPos(), 4);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 110000000);
QCOMPARE(testObject.cursorPos(), 3);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 100000000);
QCOMPARE(testObject.cursorPos(), 2);
testObject.backspacePressed(); // removes the 'dot'
QCOMPARE(testObject.value(), 100000000);
QCOMPARE(testObject.cursorPos(), 1);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 0);
QCOMPARE(testObject.cursorPos(), 0);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 0);
QCOMPARE(testObject.cursorPos(), 0);
testObject.addSeparator();
QCOMPARE(testObject.value(), 0);
QCOMPARE(testObject.cursorPos(), 2);
testObject.addSeparator();
QCOMPARE(testObject.cursorPos(), 2);
testObject.insertNumber('6');
QCOMPARE(testObject.value(), 60000000);
QCOMPARE(testObject.cursorPos(), 3);
/* when changing unit, do not change the typed text, just the interpreted value */
FloweePay::instance()->setUnit(FloweePay::MilliBCH);
QCOMPARE(testObject.value(), 60000);
testObject.setEnteredString("0");
QCOMPARE(testObject.cursorPos(), 1);
testObject.insertNumber('0');
QCOMPARE(testObject.value(), 0);
QCOMPARE(testObject.cursorPos(), 1);
testObject.insertNumber('0');
QCOMPARE(testObject.value(), 0);
QCOMPARE(testObject.cursorPos(), 1);
}
void TestValue::insertAtCursor()
{
MockBitcoinValue testObject;
testObject.setEnteredString("156.1");
QCOMPARE(testObject.value(), 15610000000);
QCOMPARE(testObject.cursorPos(), 5);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 4);
testObject.insertNumber('4');
QCOMPARE(testObject.value(), 15641000000);
QCOMPARE(testObject.cursorPos(), 5);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 4);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 3);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 2);
QCOMPARE(testObject.value(), 15641000000);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 1641000000);
QCOMPARE(testObject.cursorPos(), 1);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 2);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 3);
testObject.backspacePressed();
QCOMPARE(testObject.value(), 164100000000);
QCOMPARE(testObject.cursorPos(), 2);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 1);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 0);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 0);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 1);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 2);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 3);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 4);
testObject.moveRight();
QCOMPARE(testObject.cursorPos(), 4);
testObject.backspacePressed();
QCOMPARE(testObject.cursorPos(), 3);
QCOMPARE(testObject.value(), 16400000000);
testObject.moveLeft();
QCOMPARE(testObject.cursorPos(), 2);
testObject.addSeparator();
QCOMPARE(testObject.cursorPos(), 3);
QCOMPARE(testObject.value(), 1640000000);
}
void TestValue::fiatValues()
{
MockBitcoinValue testObject;
testObject.setMaxFractionalDigits(2);
// this sets it to a fiat mode, like the Euro
testObject.setEnteredString("4.5");
QCOMPARE(testObject.cursorPos(), 3);
QCOMPARE(testObject.value(), 450);
testObject.insertNumber('7');
QCOMPARE(testObject.cursorPos(), 4);
QCOMPARE(testObject.value(), 457);
testObject.insertNumber('5');
QCOMPARE(testObject.cursorPos(), 4);
QCOMPARE(testObject.value(), 457);
testObject.setCursorPos(0);
QCOMPARE(testObject.cursorPos(), 0);
QCOMPARE(testObject.value(), 457);
testObject.insertNumber('3');
QCOMPARE(testObject.cursorPos(), 1);
QCOMPARE(testObject.value(), 3457);
}
void TestValue::setText()
{
MockBitcoinValue testObject;
testObject.setEnteredString("1.23456789");
QCOMPARE(testObject.value(), 123456789);
FloweePay::instance()->setUnit(FloweePay::BCH);
QCOMPARE(testObject.value(), 123456789);
FloweePay::instance()->setUnit(FloweePay::MilliBCH);
QCOMPARE(testObject.value(), 123456);
FloweePay::instance()->setUnit(FloweePay::MicroBCH);
QCOMPARE(testObject.value(), 123);
FloweePay::instance()->setUnit(FloweePay::Bits);
QCOMPARE(testObject.value(), 123);
FloweePay::instance()->setUnit(FloweePay::Satoshis);
QCOMPARE(testObject.value(), 1);
FloweePay::instance()->setUnit(FloweePay::BCH);
QCOMPARE(testObject.value(), 123456789);
}
QTEST_MAIN(TestValue)
Reference in New Issue View Git Blame Copy Permalink