Follow the coding styleguide and make the methods lowercase on CKey
setting an incorrect value should not keep the old data after we already update the fValid boolean. That would give the user the impression that the data was removed while it really isn't.
This removes some unused includes from common headers and dead code from some C++ files.
Feeling cute, may update this API later. namespace Script { struct State { State() = default; State(uint32_t flags) : flags(flags) {} uint32_t flags = SCRIPT_VERIFY_NONE; // validation flags ScriptError error = SCRIPT_ERR_OK; const char* errorString() const; }; bool eval(std::vector<std::vector<unsigned char> > &stack, const CScript &script, const BaseSignatureChecker checker, Script::State &state); bool verify(const CScript& scriptSig, const CScript& scriptPubKey, const BaseSignatureChecker& checker, Script::State &state); bool checkTransactionSignatureEncoding(const std::vector<unsigned char> &vchSig, State &state); } More of the same.
tomFlowee
TomZ