Commit Graph

377 Commits

Author SHA1 Message Date
TomZ 6f2584f14d Fix off-by-one
The test was on the pprev, so we need a +1
2020-11-17 23:11:05 +01:00
TomZ 262706cf8e Make loading faulty data more robust
Instead of an assert when we encouter faulty data this moves the error
up the stack and allows for rollback.
2020-11-17 20:59:11 +01:00
TomZ dad1a0e0c0 Hardcode blockheight for DAA PU
Now the protocol upgrade went smooth, we take the effective details
and hardcode the blockheight for each chain we support.
2020-11-16 15:32:28 +01:00
TomZ 449e84338c Catch more errors while removing the 'unspent' dir content.
We now handle various more corner cases when preparing the unspent dir
for reindexing.
2020-11-10 22:38:50 +01:00
TomZ 9128660272 Fix the hardcoded number for different LANG
atof uses locales, so lets drop the decimals.
2020-11-10 22:18:53 +01:00
TomZ a966ffb129 Remove the hardcoded max message size.
We already had in place the blockSizeAcceptLimit as the limit
on messages, which is now the only limit.

In practice this means when the operator sets the maximum mining
size that we adjust the blockSizeAcceptLimit, if they only set the
blockSizeAcceptLimit, we use that (plus a margin) to limit messages
both on the p2p layer and on the RPC (JSON) layer we change the
limit to be twice the blockSizeAcceptLimit (copied those numbers
from BCHN).
2020-11-10 18:33:07 +01:00
TomZ 8c15b5942f Make scalenet easier to use
This adds a parameter interaction. Starting scalenet sets the
maxblocksize (mining) and blocksizeAcceptLimit to be 250MiB.
2020-11-10 17:25:56 +01:00
TomZ f7729fd08d Update chainparams for the scalenet. 2020-10-30 15:39:56 +01:00
TomZ bf8e4aa3fc Remove silly checkpoint. 2020-10-29 20:17:15 +01:00
TomZ 60f754ef58 Make reindex not delete the 'unspent' dir, but its contents
This is a feature request following the fact that some sysops use a
symlink for the unspent dir and don't want the reindex to delete the
symlink itself.
2020-10-29 18:56:04 +01:00
TomZ 2d90ade9d2 Update specification for testnet4 to actually validate.
Specifically: SCRIPT_ENABLE_SCHNORR.
2020-10-29 18:56:04 +01:00
TomZ 016d9565f2 Remove old detection of outdated UTXO
We have had our new format for so long, this only can give false-
positives now.
2020-10-29 18:56:04 +01:00
TomZ 6d330622f2 Handle whitelisted nodes different for DSProof punishment. 2020-10-27 16:33:08 +01:00
TomZ 42d883d418 A block inherits its 'tree' status. 2020-10-27 16:33:08 +01:00
TomZ 67cf8955b0 Drop usage of old log-style. 2020-10-27 16:33:08 +01:00
TomZ e7b0995b1a Make testnet4 have standardness rules on 2020-10-26 18:21:52 +01:00
TomZ 267e5bf142 Fix typo in comment. 2020-10-23 22:33:24 +02:00
TomZ ff0cec682e Minor cleanups
Avoid copy/paste of comments.
Remove double semicolons.
Add new seeder.
2020-10-13 19:27:35 +02:00
Justaphf 18ca7abb7c Add scalenet 2020-10-02 18:43:52 -04:00
Justaphf 13286db582 Add testnet4 2020-10-02 18:43:52 -04:00
Justaphf 2edd43806f Activate Nov 2019 & May 2020 HFs by height instead of MTP
and update the definitions of the Mainnet, Testnet (v3), and Regtest chain params accordingly.  The heights for all 3 chains were taken by verifying the values in both BU and BCHN code bases.

NOTE: For TestNet v3, there is a 1 block discrepancy between BU (1378461) and BCHN (1378460) for the height of the May 2020 hardfork.  I arbitrarily selected the value from BCHN, I'm not sure which is correct.
2020-10-02 18:43:51 -04:00
TomZ 54329bf9e4 Add new DSP test to check for stupid usage :) 2020-09-30 10:27:51 +02:00
TomZ 14a938d54c Add speed test
To make sure that a pair of really large transactions being used
to create a DSP doesn't cause a blocking thread, this runs a
benchmark on a pair of transactions with 300 inputs each, causing
45k comparisons to be made.
On my laptop this results in 0.6 msecs for this creation of the DSP.
2020-09-29 20:35:41 +02:00
TomZ fdaa6e4a81 Import some improvements from Calin.
* API docs
* Fix possible race condition in addOrphan()
* Reject proofs that violate simple constraints
* clear up possible confusing API (first/double spender getters).
2020-09-29 17:33:20 +02:00
TomZ fcc3b094ef [API] Improve featureset of MempoolSearch
The mempool search now shares its serialization code with the blockchain
transaction fetcher, allowing all the filtering and include flags to work
here too.
This also fixes several bugs and reverts the mempool API change.
Additionally I return the FirstSeenTime for each mempool entry.

There is a slight API breakage in the LiveTransactions service, which as
far as I know is still unused outside of Flowee.
These enum values changed:
Api::LiveTransactions::
  Transaction   20 =>  25
  UnspentState  23 => 26
  OutputScript  24 => 23

The reason for this change is to have the Blockchain namespace in
sync with the LiveTransactions namespace for similar features.
2020-09-14 15:27:15 +02:00
TomZ 88028c3c77 Make flags be initialized faster
This fixes a regression which caused the hub on startup to not get any
validation flags until a new block was added to the chain.
2020-09-11 18:54:21 +02:00
TomZ 6fb9310007 Avoid work
When a block header is rejected before it has been added to the header-
chain, we don't have to update the header-chain.
2020-09-11 18:54:21 +02:00
TomZ db9a80f8eb [API] Add support to query the mempool
This allows a search based on TxId or output-script-hash for
mempool transactions.
We include double spend proof info when available in the reply
2020-09-11 14:07:14 +02:00
TomZ 7e59d0c242 Remove loud log message 2020-08-16 14:53:13 +02:00
TomZ acd142a0e6 Fix logic wrt signed/unsigned
The typedef was an unsigned type, and comparisons failed.
2020-08-16 12:22:00 +02:00
TomZ 679374e923 Revert chain-switching idea
It becomes messy due to the usage of the compact form on block headers.
2020-08-16 12:03:19 +02:00
TomZ ac6b4934f2 Fix off-by-one in isStandard
Our max tx size has always been 100KB, the implementation rejected 100KB
and above, though.
This follows the major clients doing ths same.
2020-08-16 12:03:12 +02:00
TomZ 750bd23b27 Work around badly picked default variable value.
A not yet saved file has file-index zero, which is valid...
Also check this state and allow deletion of rev zero.
2020-08-13 18:28:43 +02:00
TomZ 59c468decf We now check if a revert file has become useless and delete it
If we are past at least 2000 blocks of the items stored in a data file we
can delete the revert file and save a couple hundred megabytes of
on-disk storage for every blk file.
2020-08-13 13:32:01 +02:00
TomZ 90988c80a9 Fix reindex sometimes taking forever on a block file. 2020-08-13 11:45:02 +02:00
TomZ 84ebae427e Import ASERT DAA
This includes renaming some methods which makes the import look larger
than it really is.
2020-08-12 21:42:54 +02:00
TomZ 337b34ea8e Update error message
We seem to be having a LOT of p2sh double spends on mainnet today,
which caused confusion with people reading the logs.
This clarifies that the current version only supports p2pkh and we
need more research to support others too.
2020-08-10 10:13:02 +02:00
TomZ d2802474c5 Add bchd testnet seeds 2020-08-10 10:13:02 +02:00
TomZ c4d5304d52 Make findOrphans() method const 2020-08-10 10:13:02 +02:00
TomZ 297a22dfa8 Move and fix partitionCheck()
Small refactor; move the partition check away from main and the obsolete
global variables we used to use, instead now just add it to the DB which
owns the data it works on.

This fixes the bug that in various cases we'd incorrectly get a warning
about no blocks being found in the last N hours.
2020-08-10 10:13:02 +02:00
TomZ 513bde1f7a Avoid unneeded check 2020-07-23 14:46:15 +02:00
TomZ fa18524d77 Update URL to ref-doc. 2020-06-08 18:05:05 +02:00
TomZ 5dce540238 Make clang happy; override 2020-05-27 12:14:15 +02:00
TomZ 60f1864b74 API review. Use isClosingDown() 2020-05-21 19:33:13 +02:00
TomZ b89d117475 Add checkpoints after latest protcol upgrade 2020-05-15 17:14:46 +02:00
TomZ 3c01d382d0 Merge branch '2020.03' 2020-05-15 15:45:06 +02:00
TomZ 21f519190d Fix copy/paste issue 2020-05-15 15:13:52 +02:00
TomZ 991da54d3c List our own seeder too 2020-05-06 10:39:47 +02:00
TomZ b51d15e3c5 Add some more comments and sanity checks 2020-05-03 19:52:44 +02:00
TomZ 2f7f7cec4c Nicely initialize the variable every loop 2020-04-24 10:41:55 +02:00